Merged
Conversation
richardnuno
approved these changes
Jun 30, 2025
ChrisBr
force-pushed
the
cbruckmayer/fix-ack-logic
branch
4 times, most recently
from
e43f2a6 to
98b87d0
Compare
ChrisBr
force-pushed
the
cbruckmayer/fix-ack-logic
branch
2 times, most recently
from
0017b91 to
1e68476
Compare
| redis.call('zrem', zset_key, test) | ||
| redis.call('hdel', owners_key, test) -- Doesn't matter if it was reclaimed by another workers | ||
| local acknowledged = redis.call('sadd', processed_key, test) | ||
| local acknowledged = redis.call('sadd', processed_key, test) == 1 |
Contributor
There was a problem hiding this comment.
I think the mistake was to think Lua consider 0 as falsey.
casperisfine
approved these changes
Jun 30, 2025
ChrisBr
force-pushed
the
cbruckmayer/fix-ack-logic
branch
6 times, most recently
from
2234eef to
d2e404a
Compare
ChrisBr
force-pushed
the
cbruckmayer/fix-ack-logic
branch
from
d2e404a to
f9a9894
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saddreturns the number of added entries so it always returns a truthy value. We have to== 1.This can result in race conditions for lost tests when another worker marks a lost test as processed but then fails on the original worker.