Skip to content

Tell why build aborted #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisBr merged 1 commit into from
Mar 12, 2025
Merged

Tell why build aborted #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ruby/lib/ci/queue/redis/supervisor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ def wait_for_workers
yield if block_given?
end

puts "Aborting, it seems all workers died." if time_left_with_no_workers <= 0
puts "Aborting, timed out." if time_left <= 0 && !exhausted?
puts "Aborting, it seems all workers died." if time_left_with_no_workers <= 0 && !exhausted?
Copy link
Contributor Author

@ChrisBr ChrisBr Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not added max test failed checked because that's done in the runner.

https://github.com/Shopify/ci-queue/blob/b01ba9a14ec20a2e99608ac921b0a13bb548202f/ruby/lib/minitest/queue/runner.rb


exhausted?
rescue CI::Queue::Redis::LostMaster
false
Expand Down
Loading