Skip to content

Add optional attributes message and stacktrace to skipped children in JunitXML #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisBr merged 1 commit into from
Feb 27, 2025
Merged

Add optional attributes message and stacktrace to skipped children in JunitXML #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ruby/lib/minitest/queue/junit_reporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ def add_tests_to(testsuites, suite, tests)
def add_xml_message_for(testcase, test)
failure = test.failure
if test.skipped? && !test.flaked?
testcase.add_element('skipped', 'type' => failure.error.class.name)
skip = testcase.add_element('skipped', 'type' => failure.error.class.name, 'message' => truncate_message(failure.message))
skip.add_text(REXML::CData.new(message_for(test)))
elsif test.error?
error = testcase.add_element('error', 'type' => failure.error.class.name, 'message' => truncate_message(failure.message))
error.add_text(REXML::CData.new(message_for(test)))
Expand Down
26 changes: 23 additions & 3 deletions ruby/test/integration/minitest_redis_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,10 +674,22 @@ def test_junit_reporter
<testsuites>
<testsuite name="ATest" filepath="test/dummy_test.rb" skipped="5" failures="1" errors="0" tests="6" assertions="5" time="X.XX">
<testcase name="test_foo" classname="ATest" assertions="0" time="X.XX" timestamp="X.XX" flaky_test="false" run-command=\"bundle exec ruby -Ilib:test test/dummy_test.rb -n ATest\\#test_foo\" lineno="5">
<skipped type="Minitest::Skip"/>
<skipped type="Minitest::Skip" message="Skipped, no message given">
<![CDATA[
Skipped:
test_foo(ATest) [test/dummy_test.rb]:
Skipped, no message given
]]>
</skipped>
</testcase>
<testcase name="test_bar" classname="ATest" assertions="1" time="X.XX" timestamp="X.XX" flaky_test="false" run-command=\"bundle exec ruby -Ilib:test test/dummy_test.rb -n ATest\\#test_bar\" lineno="5">
<skipped type="Minitest::Assertion"/>
<skipped type="Minitest::Assertion" message="Expected false to be truthy.">
<![CDATA[
Skipped:
test_bar(ATest) [test/dummy_test.rb]:
Expected false to be truthy.
]]>
</skipped>
</testcase>
<testcase name="test_flaky" classname="ATest" assertions="1" time="X.XX" timestamp="X.XX" flaky_test="true" run-command=\"bundle exec ruby -Ilib:test test/dummy_test.rb -n ATest\\#test_flaky\" lineno="5">
<failure type="Minitest::Assertion" message="Expected false to be truthy.">
Expand Down Expand Up @@ -710,7 +722,15 @@ def test_junit_reporter
</testsuite>
<testsuite name="BTest" filepath="test/dummy_test.rb" skipped="1" failures="0" errors="1" tests="3" assertions="1" time="X.XX">
<testcase name="test_bar" classname="BTest" assertions="0" time="X.XX" timestamp="X.XX" flaky_test="false" run-command="bundle exec ruby -Ilib:test test/dummy_test.rb -n BTest\\#test_bar" lineno="36">
<skipped type="TypeError"/>
<skipped type="TypeError" message="TypeError: String can&apos;t be coerced into Integer">
<![CDATA[
Skipped:
test_bar(BTest) [test/dummy_test.rb]:
TypeError: String can't be coerced into Integer
test/dummy_test.rb:37:in `+'
test/dummy_test.rb:37:in `test_bar'
]]>
</skipped>
</testcase>
<testcase name="test_foo" classname="BTest" assertions="1" time="X.XX" timestamp="X.XX" flaky_test="false" run-command="bundle exec ruby -Ilib:test test/dummy_test.rb -n BTest\\#test_foo" lineno="36"/>
<testcase name="test_bar" classname="BTest" assertions="0" time="X.XX" timestamp="X.XX" flaky_test="false" run-command="bundle exec ruby -Ilib:test test/dummy_test.rb -n BTest\\#test_bar" lineno="36">
Expand Down
16 changes: 14 additions & 2 deletions ruby/test/minitest/reporters/junit_reporter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,13 @@ def test_generate_junitxml_for_skipped_test
<testsuites>
<testsuite name="Minitest::Test" filepath="test/my_test.rb" skipped="1" failures="0" errors="0" tests="1" assertions="1" time="0.12">
<testcase name="test_foo" classname="Minitest::Test" assertions="1" time="0.12" flaky_test="false" run-command="bundle exec ruby -Ilib:test test/my_test.rb -n Minitest::Test\\#test_foo" lineno="12">
<skipped type="Minitest::Skip"/>
<skipped type="Minitest::Skip" message="Minitest::Skip">
<![CDATA[
Skipped:
test_foo(Minitest::Test) [test/my_test.rb]:
Minitest::Skip
]]>
</skipped>
</testcase>
</testsuite>
</testsuites>
Expand Down Expand Up @@ -140,7 +146,13 @@ def test_generate_junitxml_for_requeued_test
<testsuites>
<testsuite name="Minitest::Test" filepath="test/my_test.rb" skipped="1" failures="0" errors="0" tests="1" assertions="1" time="0.12">
<testcase name="test_foo" classname="Minitest::Test" assertions="1" time="0.12" flaky_test="false" run-command="bundle exec ruby -Ilib:test test/my_test.rb -n Minitest::Test\\#test_foo" lineno="12">
<skipped type="Minitest::Assertion"/>
<skipped type="Minitest::Assertion" message="Failed">
<![CDATA[
Skipped:
test_foo(Minitest::Test) [test/my_test.rb]:
Failed
]]>
</skipped>
</testcase>
</testsuite>
</testsuites>
Expand Down
Loading