feat: add support for --export-skipped-tests-file#302
Closed
andheiberg wants to merge 1 commit intomainfrom
Closed
feat: add support for --export-skipped-tests-file#302andheiberg wants to merge 1 commit intomainfrom
andheiberg wants to merge 1 commit intomainfrom
Conversation
SFR has ended up with tests being skipped that shouldn't be skipped. I want to add a CI check confirming that no test wasn't skipped that wasn't explicitly in a test_todo.yml file. To acheive this I need the ci-queue to report which tests were skipped.
Contributor
|
I would like to avoid storing more data into Redis and adding more options / complexity unless there is a very good reason. For skipped tests I'm not sure we need to store it in a distributed way. Maybe we could just do it in a reporter. class SkipAllowListReporter < Minitest::Reporters::BaseReporter
def initialize(options = {})
super
@allow_list = Set.new(File.read_lines(options.delete(:allow_list)))
end
def record(test)
super
raise "boom" if test.skipped? && !allow_list.include?(test.name)
end
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've observed failing tests being skipped in a codebase even though the test file wasn't employing the clear and self documenting "skip" method to achieve this. At scale this makes it hard to reason about which tests are actually run and which are skipped.
I wish to create a central file
test_todo.ymlcontaining all tests that are allowed to be skipped like so:Then I can write a CI job that complains if tests not explicitly marked as skipped centrally is skipped.