Skip to content

insert profiling middleware after Rack::Events #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmansoob wants to merge 1 commit into
base: main
Choose a base branch
from
Open

insert profiling middleware after Rack::Events #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/app_profiler/railtie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@ class Railtie < Rails::Railtie
if (Rails.env.development? || Rails.env.test?) && AppProfiler.stackprof_viewer.remote?
app.middleware.insert_before(0, AppProfiler.viewer::Middleware)
end
app.middleware.insert_before(0, AppProfiler.middleware)
if AppProfiler.otel_instrumentation_enabled
Copy link
Contributor Author

@bmansoob bmansoob Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otel gems use Rack::Events. So inserting the profiling middleware, after Rack::Events, based on the config value makes sense to me.

What do you think @gmcgibbon?

Copy link
Member

@gmcgibbon gmcgibbon Mar 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does otel itself add them events middleware? A vanilla app doesn't have it. If so, this is ok.

Copy link
Contributor Author

@bmansoob bmansoob Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/instrumentation/rack/lib/opentelemetry/instrumentation/rack/instrumentation.rb#L32-L48.

app.middleware.insert_after(Rack::Events, AppProfiler.middleware)
else
app.middleware.insert_before(0, AppProfiler.middleware)
end
end
end

Expand Down