Reintroduce VernierBackend definition check #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmansoob
approved these changes
Jan 29, 2025
gmcgibbon
approved these changes
Jan 29, 2025
lib/app_profiler.rb
Outdated
|
|
||
| def vernier_supported? | ||
| RUBY_VERSION >= "3.2.1" | ||
| defined?(AppProfiler::Backend::VernierBackend.name) && RUBY_VERSION >= "3.2.1" |
Member
There was a problem hiding this comment.
These conditions should probably be reversed. The version check is likely lighter than the defined? check.
Contributor
Author
There was a problem hiding this comment.
I was thinking we should prioritize the one that's more likely to fail. Wdyt?
Contributor
Author
There was a problem hiding this comment.
I guess it's so cheap that it's better to skip defined? whenever we can. I'll change it.
Member
There was a problem hiding this comment.
I'd like to open an issue to make it so we don't have to use defined? at all, so I'll record my thoughts there. We should not need to reference a const that loads vernier unless the user configures the gem to do so.
We have to safely ensure vernier is available and we can load the constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to safely ensure vernier is available and we can load the constant