Require time zone core_ext instead of class #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use Time.zone, which is a core extension. If it isn't loaded, we may not be able to access the zone correctly.
Member
Author
|
The timeouts appear to be happening on main prior to my changes. 🤔 I don't think this will fix them. Though, I think this is a more appropriate require. |
Depending on the state of the app, time zones may or may not be loaded at the time of profiling. This means we should require time zones support where we use it so that profiling will always work. This is specifically an issue for boot-time profiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Time.zone, which is a core extension. If it isn't loaded, we may not be able to access the zone correctly.
https://github.com/Shopify/app_profiler/actions/runs/11962066460/job/33349616705