[Code red] handle HOSTUNREACH and EADDRNOTAVAIL syscall errors (version 3.5.0) #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximus1108
requested review from
Copilot,
hamishmorgan,
jbalsas,
luanpy,
nwpan and
stevenpslade
maximus1108
force-pushed
the
connection-err-for-ehostunreach-and-eaddrnot-avail
branch
from
cee4e2a to
9ff93f9
Compare
maximus1108
requested review from
aminh-tran,
george-ma,
kevinjalbert and
nargesashrafizadeh
nwpan
approved these changes
Feb 4, 2025
nwpan
left a comment
nwpan
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making this change. 🙏
…eUtils::ConnectionError
maximus1108
force-pushed
the
connection-err-for-ehostunreach-and-eaddrnot-avail
branch
from
9ff93f9 to
3847f68
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
EHOSTUNREACHandEADDRNOTAVAILsyscall errors asActiveUtils::ConnectionErrorWhy?
Resolves https://github.com/Shopify/shopify/issues/576905 and similar issues
EHOSTUNREACHis returned when a host is unreachable due to network conditions such as firewall rules.EADDRNOTAVAILis returned when the host is address is not valid - this specifically happens in Core when for hosts such aslocalhostwhich are not permitted.Although not highly prevalent, it does create noise among our exceptions and these errors are not exceptional. Below are some rough numbers on these errors (query)
We should raise these as
ActiveUtils::ConnectionErrorbecause they're generally they're not transient and retries would be ineffective. This is also helpful for existing users of this library because most are already handlingActiveUtils::ConnectionErrorappropriately