feat!(sim): Use g4Config.yaml instead of deprecated .C#841
Open
feat!(sim): Use g4Config.yaml instead of deprecated .C#841
Conversation
Contributor
Author
|
Fails because I'll return to this when I'm back (or left as exercise for the reader). |
Contributor
Author
|
Build failure should be fixed once we switch the CI to a config using ShipSoft/shipdist#115 |
olantwin
force-pushed
the
gconfig_yaml
branch
5 times, most recently
from
71d6cf4 to
7fc8a1c
Compare
Contributor
Author
|
First results look ok. More detailed testing needed, but particle and hit distributions look normal. |
Contributor
Author
|
@siilieva Probably also of interest for SND@(HL-)LHC |
Contributor
Author
|
It should be possible to test whether the same set of options reach geant4 and that the stack is the same. |
olantwin
force-pushed
the
gconfig_yaml
branch
2 times, most recently
from
ff2dad8 to
34f994f
Compare
Add YAML config including all settings from .C. Set ShipStack and its options explicitly in simulation scripts. Thorough testing needed. Fixed #543
- Physics list: QGSP_BERT_HP_PEN → FTFP_BERT_HP_EMZ - Restore /process/em/UseGeneralProcess false - Restore /mcPhysics/setExtDecayerSelection J/psi - Comment out Geant4_MaxNStep (keep default 30000) - Remove /mcPhysics/g4NeutronHPVerbose (removed in newer Geant4)
VMCConfig inherits from FairYamlVMCConfig but the MCConfigurator library was missing from the link dependencies, causing undefined symbol errors.
olantwin
force-pushed
the
gconfig_yaml
branch
from
a55623d to
1a3cc96
Compare
FairRoot::MCConfigurator has transitive dependencies on Geant4 CMake targets (via FairRoot::FastSim -> Geant4::G4processes). Call native find_package(Geant4) before FairRoot to ensure these targets exist.
olantwin
force-pushed
the
gconfig_yaml
branch
from
c522da3 to
59bc8a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add YAML config including all settings from .C. Set ShipStack and its options explicitly in simulation scripts.
Thorough testing needed.
Fixes #543