Skip to content

refactor: use modern ROOT dictionary generation in ship_add_library#1024

Merged
olantwin merged 1 commit intomasterfrom
target_root_dictionary
Feb 6, 2026
Merged

refactor: use modern ROOT dictionary generation in ship_add_library#1024
olantwin merged 1 commit intomasterfrom
target_root_dictionary

Conversation

@olantwin
Copy link
Contributor

@olantwin olantwin commented Feb 4, 2026

Replace FairRoot's scope-variable-driven FAIRROOT_GENERATE_DICTIONARY() with the modern target-based CMake. This:

  • Invokes rootcling directly instead of via a shell script wrapper
  • Reads include directories from target properties via generator expressions
  • Removes all scope variable manipulation (LIBRARY_NAME, HDRS, DICTIONARY, LINKDEF, LIBRARY_OUTPUT_PATH, INCLUDE_DIRECTORIES, SYSTEM_INCLUDE_DIRECTORIES)
  • Requires library creation before dictionary generation (reorder in ship_add_library)

Checklist

@olantwin olantwin requested a review from a team as a code owner February 4, 2026 09:57
@olantwin olantwin force-pushed the target_root_dictionary branch 6 times, most recently from 145ac7e to 1589ce9 Compare February 6, 2026 14:23
@olantwin olantwin force-pushed the target_root_dictionary branch from 1589ce9 to cf5e52b Compare February 6, 2026 15:20
@olantwin olantwin changed the title refactor: switch to fairroot_target_root_dictionary for dictionary ge… refactor: use modern ROOT dictionary generation in ship_add_library Feb 6, 2026
@olantwin olantwin merged commit e111bcf into master Feb 6, 2026
7 checks passed
@olantwin olantwin deleted the target_root_dictionary branch February 6, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant