Skip to content

feat: New warm MS option Stellatryon v.2 added#1011

Open
Gfrisella wants to merge 1 commit intoShipSoft:masterfrom
Gfrisella:warm-ms-stellatryon-v2
Open

feat: New warm MS option Stellatryon v.2 added#1011
Gfrisella wants to merge 1 commit intoShipSoft:masterfrom
Gfrisella:warm-ms-stellatryon-v2

Conversation

@Gfrisella
Copy link
Contributor

@Gfrisella Gfrisella commented Jan 27, 2026

Checklist

@Gfrisella Gfrisella requested a review from a team as a code owner January 27, 2026 09:34
@Gfrisella Gfrisella force-pushed the warm-ms-stellatryon-v2 branch from b8b6c5f to 42c3809 Compare January 27, 2026 09:52
Copy link
Contributor

@olantwin olantwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set of comments. More to come.

Please make sure run_fixedTarget.py also runs and that the overlaps are fixed.

@olantwin olantwin requested a review from THanae January 27, 2026 13:04
@olantwin
Copy link
Contributor

For the SND support, @antonioiuliano2 @eduard322, could you have a look?

Copy link
Contributor

@olantwin olantwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments

Copy link
Contributor

@olantwin olantwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also confused about warm_opt. run_simScript.py, run_fixedTarget, CI and Changelog all disagree.

@Gfrisella
Copy link
Contributor Author

@eduard322 @antonioiuliano2

I believe that the SND is currently fixed at a set position along the Z-axis and therefore does not adapt to changes in the Muon Shield (MS) configuration.

=== Overlaps for FAIRGeom ===
 = Overlap ov00000: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagL_1 ovlp=18
 = Overlap ov00001: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagR_1 ovlp=18
 = Overlap ov00002: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetL_1 ovlp=9.82
 = Overlap ov00003: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetR_1 ovlp=9.82

I already modified the code in ShipMuonShield.cxx in order to create an aperture in the middle of the last two magnets; however, the SND location appears to be hard-coded in the Python script. As a result, overlaps occur between Magnet 3 (the last magnet in this case is Magnet 5) and the MTC.

@eduard322
Copy link
Contributor

hi @Gfrisella, the SND location is glued to the center of the chosen magnet, i’ll modify it.

@eduard322
Copy link
Contributor

@eduard322 @antonioiuliano2

I believe that the SND is currently fixed at a set position along the Z-axis and therefore does not adapt to changes in the Muon Shield (MS) configuration.

=== Overlaps for FAIRGeom ===
 = Overlap ov00000: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagL_1 ovlp=18
 = Overlap ov00001: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagR_1 ovlp=18
 = Overlap ov00002: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetL_1 ovlp=9.82
 = Overlap ov00003: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetR_1 ovlp=9.82

I already modified the code in ShipMuonShield.cxx in order to create an aperture in the middle of the last two magnets; however, the SND location appears to be hard-coded in the Python script. As a result, overlaps occur between Magnet 3 (the last magnet in this case is Magnet 5) and the MTC.

Here is the commit with changes of the MTC and SiW locations (python/shipDetConf.py is changed): eduard322@f7e62ce

Feel free to cherry-pick it.

@Gfrisella
Copy link
Contributor Author

@eduard322 @antonioiuliano2
I believe that the SND is currently fixed at a set position along the Z-axis and therefore does not adapt to changes in the Muon Shield (MS) configuration.

=== Overlaps for FAIRGeom ===
 = Overlap ov00000: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagL_1 ovlp=18
 = Overlap ov00001: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagR_1 ovlp=18
 = Overlap ov00002: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetL_1 ovlp=9.82
 = Overlap ov00003: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetR_1 ovlp=9.82

I already modified the code in ShipMuonShield.cxx in order to create an aperture in the middle of the last two magnets; however, the SND location appears to be hard-coded in the Python script. As a result, overlaps occur between Magnet 3 (the last magnet in this case is Magnet 5) and the MTC.

Here is the commit with changes of the MTC and SiW locations (python/shipDetConf.py is changed): eduard322@f7e62ce

Feel free to cherry-pick it.

Please add also the possibility to choose the magnet, in a new version of MS we are studying the possibility to use the two magnets before the last one for the SND

@eduard322
Copy link
Contributor

@eduard322 @antonioiuliano2
I believe that the SND is currently fixed at a set position along the Z-axis and therefore does not adapt to changes in the Muon Shield (MS) configuration.

=== Overlaps for FAIRGeom ===
 = Overlap ov00000: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagL_1 ovlp=18
 = Overlap ov00001: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagR_1 ovlp=18
 = Overlap ov00002: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetL_1 ovlp=9.82
 = Overlap ov00003: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetR_1 ovlp=9.82

I already modified the code in ShipMuonShield.cxx in order to create an aperture in the middle of the last two magnets; however, the SND location appears to be hard-coded in the Python script. As a result, overlaps occur between Magnet 3 (the last magnet in this case is Magnet 5) and the MTC.

Here is the commit with changes of the MTC and SiW locations (python/shipDetConf.py is changed): eduard322@f7e62ce
Feel free to cherry-pick it.

Please add also the possibility to choose the magnet, in a new version of MS we are studying the possibility to use the two magnets before the last one for the SND

hey, can you send me the picture of the muon shield and with snd locations you consider. I’m quite confuse, should SiW and MTC be inside one magnet or as it was (SiW in the magnet before the last and MTC in the last magnet)?

@Gfrisella
Copy link
Contributor Author

@eduard322 @antonioiuliano2
I believe that the SND is currently fixed at a set position along the Z-axis and therefore does not adapt to changes in the Muon Shield (MS) configuration.

=== Overlaps for FAIRGeom ===
 = Overlap ov00000: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagL_1 ovlp=18
 = Overlap ov00001: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagR_1 ovlp=18
 = Overlap ov00002: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetL_1 ovlp=9.82
 = Overlap ov00003: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetR_1 ovlp=9.82

I already modified the code in ShipMuonShield.cxx in order to create an aperture in the middle of the last two magnets; however, the SND location appears to be hard-coded in the Python script. As a result, overlaps occur between Magnet 3 (the last magnet in this case is Magnet 5) and the MTC.

Here is the commit with changes of the MTC and SiW locations (python/shipDetConf.py is changed): eduard322@f7e62ce
Feel free to cherry-pick it.

Please add also the possibility to choose the magnet, in a new version of MS we are studying the possibility to use the two magnets before the last one for the SND

hey, can you send me the picture of the muon shield and with snd locations you consider. I’m quite confuse, should SiW and MTC be inside one magnet or as it was (SiW in the magnet before the last and MTC in the last magnet)?

This is the configuration at the moment:

image

@olantwin
Copy link
Contributor


=== Overlaps for FAIRGeom ===
 = Overlap ov00000: cave/target_vacuum_box_1 overlapping cave/MuonShieldArea_1/MagnAbsorb_MiddleMagL_1 ovlp=3.39
 = Overlap ov00001: cave/target_vacuum_box_1 overlapping cave/MuonShieldArea_1/MagnAbsorb_MiddleMagR_1 ovlp=3.39
 = Overlap ov00002: cave/target_vacuum_box_1 overlapping cave/MuonShieldArea_1/MagnAbsorb_MagRetL_1 ovlp=3.39
 = Overlap ov00003: cave/target_vacuum_box_1 overlapping cave/MuonShieldArea_1/MagnAbsorb_MagRetR_1 ovlp=3.39
 = Overlap ov00004: cave/target_vacuum_box_1 overlapping cave/MuonShieldArea_1/MagnAbsorb_MagBotLeft_1 ovlp=3.39

@eduard322
Copy link
Contributor

@eduard322 @antonioiuliano2
I believe that the SND is currently fixed at a set position along the Z-axis and therefore does not adapt to changes in the Muon Shield (MS) configuration.

=== Overlaps for FAIRGeom ===
 = Overlap ov00000: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagL_1 ovlp=18
 = Overlap ov00001: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MiddleMagR_1 ovlp=18
 = Overlap ov00002: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetL_1 ovlp=9.82
 = Overlap ov00003: cave/SiliconTarget_1 overlapping cave/MuonShieldArea_1/Magn3_MagRetR_1 ovlp=9.82

I already modified the code in ShipMuonShield.cxx in order to create an aperture in the middle of the last two magnets; however, the SND location appears to be hard-coded in the Python script. As a result, overlaps occur between Magnet 3 (the last magnet in this case is Magnet 5) and the MTC.

Here is the commit with changes of the MTC and SiW locations (python/shipDetConf.py is changed): eduard322@f7e62ce
Feel free to cherry-pick it.

Please add also the possibility to choose the magnet, in a new version of MS we are studying the possibility to use the two magnets before the last one for the SND

hey, can you send me the picture of the muon shield and with snd locations you consider. I’m quite confuse, should SiW and MTC be inside one magnet or as it was (SiW in the magnet before the last and MTC in the last magnet)?

This is the configuration at the moment:

image

eduard322@f66061e

I've added the SND_location key for macro/run_simScript.py with the default value of -1 (last magnet). The flexibility fully depends on the mechanism of creating the wholes in the magnet though...

- Add warm MS option TRY_2025 v.2 and its field map
- Remove the old MS version
- Update muon shield parameters and the SND hole function
- Disable the MS magnetic field
- Skip field map upload in run_fixedTarget
- Remove the old target from CI
@Gfrisella Gfrisella force-pushed the warm-ms-stellatryon-v2 branch from f99bd64 to 48d71f5 Compare January 30, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants