Build with Maven, inserting version into plugin.yml. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix region checking code. It was picking up all regions in all worlds at specified coordinates. Now only regions applicable to the current world at the specified location are checked. * Treat all air material types equivalently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds the plugin JAR with one command,
mvn. You need only edit the version number in one file (pom.xml) to set the version number on the JAR file and inplugin.yml.If including the version number in the filename is not to your liking, I can talk you through the Maven syntax to drop the version number from the JAR file name. And I made this commit a while back when I was trying to get i0xHeX's fork built in a hurry. Consequently the version in
pom.xmlis6.0-SNAPSHOTwhich I guess you would want to change anyway before you merge.The default goal when you run
mvnis set toclean package, which builds the JAR. If you prefer, you can change the default goal toclean installto put the JAR in the local Maven repository.This PR also includes a
.gitignorefile to avoid checking in build artifacts.