Name functions and add comments in graphics.asm#10
Open
ghostlink2027 wants to merge 3 commits intoShiningForceCentral:mainfrom
Open
Name functions and add comments in graphics.asm#10ghostlink2027 wants to merge 3 commits intoShiningForceCentral:mainfrom
ghostlink2027 wants to merge 3 commits intoShiningForceCentral:mainfrom
Conversation
Created names and comments and updated labels within 3 functions and 2 tables in graphics.asm sub_157C -> lengthTimesSine sub_1794 -> squareRoot sub_17C0 -> calculateAngleFromXAndY word_1594 -> table_sineLookup byte_1814 -> table_arcsineLookup
Changed all instances of sub_314 to j_lengthTimesSine
Update references to 3 functions from graphics.asm and their alias names in the list of branch instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the names of 3 functions and 2 tables in graphics.asm and their associated labels to be more descriptive.
Added comments to describe the code's functionality and tables' purposes and values.
sub_157C -> lengthTimesSine
sub_1794 -> squareRoot
sub_17C0 -> calculateAngleFromXAndY
word_1594 -> table_sineLookup
byte_1814 -> table_arcsineLookup
Updated all references to these functions in other files.
Build succeeds with no differences reported in the ROM.