Remove secret character counts from log output#9
Merged
shiftcontrol-dan merged 3 commits intomainfrom Mar 17, 2026
Merged
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Logging the character count of resolved secrets leaks information about secret size, which can aid attackers in identifying or narrowing down credential types. Strip the char count from both the info-level resolve log and the debug-level write log. Signed-off-by: Dan Gericke <dan@shiftcontrol.io>
op_write now detects "item not found" errors from `op item edit` and falls back to `op item create --category=password`. This supports new OAuth credentials that don't have a pre-existing 1Password item. Also zeroizes the assignment string containing the secret value after CLI invocation, and extracts the error detection marker to a constant. Signed-off-by: Dan Gericke <dan@shiftcontrol.io>
shiftcontrol-dan
force-pushed
the
fix/remove-secret-char-count-from-logs
branch
from
629e14e to
1265f5e
Compare
Signed-off-by: Dan Gericke <dan@shiftcontrol.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
info!log when resolving secrets (e.g.,resolved ANTHROPIC_API_KEY (108 chars)→resolved ANTHROPIC_API_KEY)debug!log when writing secrets viaop item editTest plan
cargo checkpasses