Add support for non-square render resolutions (width != height)#96
Draft
lasagnaphil wants to merge 1 commit intoShichenLiu:masterfrom
Draft
Add support for non-square render resolutions (width != height)#96lasagnaphil wants to merge 1 commit intoShichenLiu:masterfrom
lasagnaphil wants to merge 1 commit intoShichenLiu:masterfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a working draft of a PR that adds support for rasterizing to images of non-square size (width != height).
I've modified the CUDA kernels and C++ functions, changed the Rasterizer class to accept (width, height) tuple for image_size, and have confirmed that demo_render.py is working with other image sizes. I've yet not tested the other demos though, and there might be other places in the Python API that I've missed that needs to be changed as well.
This effectively solves issue #34.
The things left to do:
Since I have limited spare time, any help on completing this PR can be appreciated (especially modifying and testing it on the Python API side).