Skip to content

return GSPGroup while reverse-geocoding to GSP #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Herald-TUOS merged 3 commits into from
Oct 21, 2025
Merged

return GSPGroup while reverse-geocoding to GSP #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1206d18
return `GSPGroup` while reverse-geocoding to GSP
Herald-TUOS Sep 25, 2025
18f4390
fix broken tests
Herald-TUOS Sep 25, 2025
d784043
Update geocode/utilities.py
Herald-TUOS Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/test_geocode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def test_reverse_geocode_gsp(self):
"""
Test the `reverse_geocode_gsp` function with several test cases.
"""
gsp_regions = ["BRED_1", "DEWP"]
gsp_regions = [("BRED_1", "_G"), ("DEWP", "_N")]
latlons = [(53.33985, -2.051880), (55.950095, -3.178485)]
with Geocoder() as geo:
assert_equal(
Expand Down
3 changes: 3 additions & 0 deletions geocode/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,9 @@ def reverse_geocode(
)
joined.update(nearest, overwrite=False)
joined["region_id"] = joined["region_id"].where(pd.notna(joined["region_id"]), None)
if "GSPGroup" in joined.columns:
Copy link
Contributor

@JamieTaylor-TUOS JamieTaylor-TUOS Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the if condition is for? won't this always evaluate to True?

Copy link
Contributor Author

@Herald-TUOS Herald-TUOS Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be True when reverse geo-coding llsoa and nuts

joined["GSPGroup"] = joined["GSPGroup"].replace({pd.NA: None})
return list(zip(joined["region_id"], joined["GSPGroup"]))
return joined["region_id"].tolist()
Comment on lines +283 to 284
Copy link
Contributor

@JamieTaylor-TUOS JamieTaylor-TUOS Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its desirable to sometime return a list of strings and other times to return a list of tuples. I think we should always return a list of tuples, or else introduce a parameter to determine whether to return the GSPGroup or not (though the latter smells a little)

Copy link
Contributor Author

@Herald-TUOS Herald-TUOS Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since llsoa and nuts doesn't need to return a list of tuples, I think we should come up with something else. Is it okay to make a separate function for reverse geo-coding gsp?



Expand Down