Add CI with Github Actions #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Github workflow actions
There was a problem hiding this comment.
Pull Request Overview
This PR implements continuous integration with GitHub Actions to automate code quality checks and builds. It also adds pre-commit hooks with Husky to ensure code quality before commits.
- Adds GitHub Actions CI workflow for linting and building on PR/push events
- Configures Husky with pre-commit hooks and lint-staged for automated code formatting
- Updates ESLint configuration to be more strict and splits lint commands for CI vs local development
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds Husky and lint-staged dependencies, splits lint commands, and configures lint-staged rules |
| eslint.config.mjs | Enables stricter TypeScript linting rules including explicit any warnings |
| .husky/pre-commit | Creates pre-commit hook to run lint-staged automatically |
| .github/workflows/ci.yml | Defines CI workflow with lint and build jobs for pull requests and main branch pushes |
.github/workflows/ci.yml
Outdated
| build: | ||
| name: Build | ||
| runs-on: ubuntu-latest | ||
| if: github.ref == 'refs/heads.main' && github.event_name == 'push' |
There was a problem hiding this comment.
The condition uses 'refs/heads.main' but should be 'refs/heads/main' (missing forward slash). This will prevent the build job from running on main branch pushes.
Suggested change
| if: github.ref == 'refs/heads.main' && github.event_name == 'push' | |
| if: github.ref == 'refs/heads/main' && github.event_name == 'push' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.