Skip to content

Feature/update deps ng 8#30

Open
GerkinDev wants to merge 2 commits intoShadowstep33:masterfrom
GerkinDev:feature/update-deps-ng-8
Open

Feature/update deps ng 8#30
GerkinDev wants to merge 2 commits intoShadowstep33:masterfrom
GerkinDev:feature/update-deps-ng-8

Conversation

@GerkinDev
Copy link

Update all deps to latest versions. Works well in one of my test app. It's annoying that there are no tests.

@Shadowstep33
Copy link
Owner

Hi @GerkinDev sorry it took me so embarassingly long to look at this. Would you mind resolving the conflict on package-lock? I think we're good to merge this in then. There's one small change I noticed I had to make locally, will add comment

@Shadowstep33
Copy link
Owner

Actually I guess it isn't in your changes but on package.json I think we need a dist/ prefix in main and typings

@GerkinDev
Copy link
Author

Hi there!
Well, I didn't changed main nor typings, as you may see in the changes of the PR.
I could think about updating for angular 10 that was released not so long ago. Tell me if you're interested. If you don't really have time & want to drop support, I totally understand
Cheers! 🍻

@Shadowstep33
Copy link
Owner

Oh yes, @GerkinDev I'm actually seeing I got confused with your master branch and feature branch. I am trying to fix the aot issue for --prod building :(

I'm not too worried about support Angular 10 tbh; I feel like they just switched to 8 so if they make 10 completely break support of older versions then that's a different kind of problem :D

@Shadowstep33
Copy link
Owner

If you don't really have time & want to drop support, I totally understand

My time is limited but I dont want to drop support. It will just continue to be slow going :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants