Fix Cargo Clippy + Updated Documentation #67
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses Cargo Clippy warnings and updates documentation. The changes primarily focus on modernizing Rust code patterns using let-chain syntax, updating IO error handling to use io::Error::other(), and significantly expanding the documentation with new server manager integration guides.
Key Changes
- Applied Clippy fixes throughout the codebase using let-chain patterns to simplify nested conditionals
- Replaced
io::Error::new(io::ErrorKind::Other, ...)withio::Error::other(...)for cleaner error handling - Added comprehensive documentation for Pterodactyl and Crafty Controller integrations in both English and French
- Updated dependency versions in Cargo.toml including opentelemetry, chrono, sysinfo, and others
Reviewed changes
Copilot reviewed 47 out of 48 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/quickstart/configuration.md | Updated configuration documentation with new server manager, proxy protocol, and MOTD options |
| docs/fr/quickstart/configuration.md | French translation of updated configuration documentation |
| docs/features/pterodactyl.md | New documentation for Pterodactyl integration |
| docs/features/crafty-controller.md | New documentation for Crafty Controller integration |
| docs/fr/features/pterodactyl.md | French translation of Pterodactyl integration guide |
| docs/fr/features/crafty-controller.md | French translation of Crafty Controller integration guide |
| docs/.vitepress/config.mts | Added navigation links for new documentation pages |
| crates/infrarust_server_manager/src/terminal/unix.rs | Updated to use io::Error::other() |
| crates/infrarust_server_manager/src/process/manager.rs | Applied let-chain patterns to simplify nested conditionals |
| crates/infrarust_server_manager/src/monitor/*.rs | Applied let-chain patterns for cleaner code |
| crates/infrarust_server_manager/src/api/*.rs | Commented out unused code and applied let-chain patterns |
| crates/infrarust_protocol/src/packet/*.rs | Updated error handling and applied let-chain patterns |
| crates/infrarust_config/src/provider/*.rs | Applied let-chain patterns throughout provider implementations |
| crates/infrarust_config/src/models/server.rs | Simplified Default trait implementation using derive macros |
| crates/infrarust_ban_system/src/*.rs | Applied let-chain patterns in ban system logic |
| crates/infrarust/src/telemetry/*.rs | Applied let-chain patterns and updated test code |
| crates/infrarust/src/security/*.rs | Updated to use io::Error::other() and let-chain patterns |
| crates/infrarust/src/proxy_modes/*.rs | Applied let-chain patterns across all proxy mode handlers |
| crates/infrarust/src/network/*.rs | Updated error handling to use io::Error::other() |
| crates/infrarust/src/core/*.rs | Applied let-chain patterns in core actor implementations |
| crates/infrarust/src/cli/*.rs | Applied let-chain patterns in CLI command handlers |
| crates/infrarust/src/lib.rs | Changed error level from error to warn for missing manager configs |
| Cargo.toml | Updated multiple dependencies to newer versions |
| Cargo.lock | Lockfile updates reflecting new dependency versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```yaml | ||
| server_manager: | ||
| provider_name: Pterodactyl |
There was a problem hiding this comment.
Incorrect provider name in example. This section describes Crafty Controller configuration, but the example shows provider_name: Pterodactyl. It should be provider_name: Crafty to match the Crafty Controller context.
|
|
||
| ```yaml | ||
| server_manager: | ||
| provider_name: Pterodactyl |
There was a problem hiding this comment.
Incorrect provider name in French example. This section describes Crafty Controller configuration, but the example shows provider_name: Pterodactyl. It should be provider_name: Crafty to match the Crafty Controller context.
| status: server_state, | ||
| is_running, | ||
| is_crashed, | ||
|
|
There was a problem hiding this comment.
Trailing whitespace should be removed for consistency with code style guidelines.
| managers_config: | ||
| pterodactyl: | ||
| enabled: true | ||
| api_key: "your_pterodactyl_api_key" # Must be a client ApiKLey that start with "ptlc_" |
There was a problem hiding this comment.
Spelling error: "ApiKLey" should be "API key"
No description provided.