fix(Steam): add better login persistence and update API version#16
fix(Steam): add better login persistence and update API version#16ShadowApex wants to merge 4 commits intomainfrom
Conversation
ShadowApex
force-pushed
the
shadowapex/login-improvements
branch
from
f4ff567 to
d0851d9
Compare
| item.provider_app_id = app_id | ||
| item.name = data["name"] | ||
| item.command = "steam" | ||
| item.args = ["-gamepadui", "-steamos3", "-steampal", "-steamdeck", "-silent", "steam://rungameid/" + app_id] |
There was a problem hiding this comment.
I think this change creates issues with Steam. I have no focus on the game, but on a black window and there is no controls. When I use the official stable release the games I tested work. MH Rise Demo and Pixel Gun 3D. Also I noticed that the UI is in BigPicture mode somehow.
There was a problem hiding this comment.
reverting that change make the controls work again. Also the correct window is focused.
ShadowApex
force-pushed
the
shadowapex/login-improvements
branch
from
d0851d9 to
34c1773
Compare
ShadowApex
force-pushed
the
shadowapex/login-improvements
branch
from
34c1773 to
590eaf7
Compare
|
Any progress on this one? @ShadowApex |
| var current_output: Array[String] = [] | ||
|
|
||
| var logger := Log.get_logger("SteamClient", Log.LEVEL.INFO) | ||
| var logger := Log.get_logger("SteamClient", Log.LEVEL.DEBUG) |
| await wait_for_network() | ||
|
|
||
|
|
||
| # Ensure the client is part of the Steam Deck beta |
There was a problem hiding this comment.
I have found different behavior depending on whether or not the Steam client is using the Steam Deck branch or not.
There was a problem hiding this comment.
I think this is more about the beta channel than if the UX for the deck is used. Based on license agreements for non steamos only the flag gamepadui should be used. However BigPicture mode still acts different than when the UX for the Steamdeck is used. There is still the hope of getting an universal handheld mode and the flag for the deck may get reduced to branding purposes. However that needs further discussions with Valve.
There was a problem hiding this comment.
There has been a difference, specifically when using the -steamos3 and -steamdeck flags, but lately I have been having some decent success just using the -gamepadui flag, so it's possible that using the Steam Deck channel may not be necessary.
| else: | ||
| users = vdf.data | ||
|
|
||
| for username in accounts.keys(): |
There was a problem hiding this comment.
I'm not sure what you mean here. Could you elaborate?
There was a problem hiding this comment.
It seems this changes the case from PascalCase to lower case sometimes?
ShadowApex
force-pushed
the
shadowapex/login-improvements
branch
4 times, most recently
from
9ca2f8b to
04040df
Compare
| var current_output: Array[String] = [] | ||
|
|
||
| var logger := Log.get_logger("SteamClient", Log.LEVEL.INFO) | ||
| var logger := Log.get_logger("SteamClient", Log.LEVEL.DEBUG) |
|
Fixes ShadowBlip/OpenGamepadUI#298 |
| if not item.provider_app_id.is_valid_int(): | ||
| return | ||
| if not _steam.is_logged_in: | ||
| return |
There was a problem hiding this comment.
Should this produce a notification window?
ShadowApex
force-pushed
the
shadowapex/login-improvements
branch
from
7f63ab1 to
2b476d8
Compare
ShadowApex
force-pushed
the
shadowapex/login-improvements
branch
from
c7281d2 to
091bce0
Compare
3 participants
No description provided.