Skip to content

Conversation

@jbliao
Copy link

@jbliao jbliao commented Feb 20, 2025

Proposed changes

Fix highlights added from UserCard not working when target user have display name

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged

@Excellify
Copy link
Contributor

Excellify commented Mar 4, 2025

Please add a changelog entry in changelog-nightly.md.
Can create 3.1.6.2000.

@jbliao jbliao force-pushed the fix/user-card-highlight branch from f0f6983 to e863259 Compare March 5, 2025 08:07
@Excellify
Copy link
Contributor

When checking the pattern we are comparing the lowercase displayname with the lowercase pattern. Do displayName and username ever vary other than capitalization?

@jbliao
Copy link
Author

jbliao commented Mar 27, 2025

When checking the pattern we are comparing the lowercase displayname with the lowercase pattern. Do displayName and username ever vary other than capitalization?

Yes, especially for non-native English speakers.
We often set our display name in our native language, which can be completely different from our username.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants