Respect XDG_CONFIG_HOME on Linux #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application's configuration is stored using `ApplicationProperties` which doesn't consider the *XDG Base Directory Specification*. There is `File::userApplicationDataDirectory` but it also doesn't respect it according to an upstream [bug report]. Supporting the full specification is more effort but just supporting `XDG_CONFIG_HOME` already addresses the common issue of the home directory being spammed with configuration files. So just read that environment variable or use its default to set the `folderName`, with an appended application name since the specification suggests to also use a subfolder. This is a breaking change for Linux users but since none are known at the time it seems acceptable to just switch instead of supporting some form of migration. It's also mentioned in the change log. [bug report]: juce-framework/JUCE#1184
ServiusHack
force-pushed
the
xdg_config_home
branch
from
8852f50 to
38f6eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application's configuration is stored using
ApplicationPropertieswhich doesn't consider the XDG Base Directory Specification. There isFile::userApplicationDataDirectorybut it also doesn't respect it according to an upstream bug report.Supporting the full specification is more effort but just supporting
XDG_CONFIG_HOMEalready addresses the common issue of the home directory being spammed with configuration files. So just read that environment variable or use its default to set thefolderName, with an appended application name since the specification suggests to also use a subfolder.This is a breaking change for Linux users but since none are known at the time it seems acceptable to just switch instead of supporting some form of migration. It's also mentioned in the change log.