add header search box suggestions#59
Open
bblaisATcoveo wants to merge 2 commits intoServiceCanada:mainfrom
Open
add header search box suggestions#59bblaisATcoveo wants to merge 2 commits intoServiceCanada:mainfrom
bblaisATcoveo wants to merge 2 commits intoServiceCanada:mainfrom
Conversation
bblaisATcoveo
temporarily deployed
to
github-ci
GitHub Actions
Inactive
GormFrank
requested changes
Feb 11, 2026
|
|
||
| // changing the URL without reloading the page to remove actionCause | ||
| if ( window.history.pushState ) { | ||
| var newurl = winLoc.href.replace( '&actionCause=' + urlParams.actionCause, '' ); |
Contributor
There was a problem hiding this comment.
You should use params.actionCause on this line
| // changing the URL without reloading the page to remove actionCause | ||
| if ( window.history.pushState ) { | ||
| var newurl = winLoc.href.replace( '&actionCause=' + urlParams.actionCause, '' ); | ||
| window.history.pushState( { path : newurl }, '', newurl ); |
Contributor
There was a problem hiding this comment.
During our next technical touchpoint with GC Search team, let's make it an item to consider and test this in case of edge cases such as other parameters used; I'm thinking Canadian Food Guide (https://food-guide.canada.ca/en/), as well as Canada Gazette (https://gazette.gc.ca/accueil-home-eng.html).
|
|
||
| // override actionCause if present | ||
| if ( params.actionCause ) { | ||
| requestContent.analytics.actionCause = params.actionCause; |
Contributor
There was a problem hiding this comment.
Wouldn't you need to clear params.actionClause it here as well?
| */ | ||
| .query-suggestions { | ||
| background-color: white; | ||
| border-bottom: 1px solid #ccc; |
Contributor
There was a problem hiding this comment.
Please remove this line since the style will apply from line 44 in this file instead. And please ensure the border color is consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the suggestions to the global search box in the header of every page