Skip to content

Minor: Make some variables available through UI, Show error when no token + Maintenance items#52

Merged
jonasg-gc merged 1 commit intoServiceCanada:mainfrom
GormFrank:maintenance
Nov 10, 2025
Merged

Minor: Make some variables available through UI, Show error when no token + Maintenance items#52
jonasg-gc merged 1 commit intoServiceCanada:mainfrom
GormFrank:maintenance

Conversation

@GormFrank
Copy link
Contributor

@GormFrank GormFrank commented Nov 3, 2025

Maintenance items include:

  • Improve caching of window variable that are used multiple times in the script, such as: window.location, then window.location.pathname
  • Show "No result" message when searching with no query term
  • "numberOfPages: 9" and "automaticallyCorrectQuery: false" now configurable through parameters
  • Revisit how dates are handled for output formats (need an array of months?) by using native JS functions toLocaleDateString
  • Ensure no #wb-land section tag (element with semantic) is added alone/empty on the page
  • Refactor/relocate some variables and function just for code readibility and efficiency
  • Improve documentation of Readme and index page
  • Add a new selector that will eventually allow for the replacement of the action="#wb-land" selector and potentially the gc-searchbox ID as well
  • Fix a 1px glitch with QS on page load, before suggestions get inserted
  • Remove "in the body of the page" dropdown option in "terms appearing" field in advanced search, which has been doing nothing different than "Anywhere in the page"
  • Fix aria-activedescendant attribute accessibility concern (as part of QS)

@GormFrank GormFrank changed the title Patch: Error when no token + Maintenance items Patch: Show error when no token + Maintenance items Nov 4, 2025
@GormFrank GormFrank requested a review from igkislev November 4, 2025 20:40
@GormFrank GormFrank marked this pull request as ready for review November 4, 2025 20:40
@GormFrank GormFrank changed the title Patch: Show error when no token + Maintenance items Minor: Make some variables available through UI, Show error when no token + Maintenance items Nov 5, 2025
igkislev
igkislev previously approved these changes Nov 5, 2025
Copy link
Contributor

@igkislev igkislev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think in the future we need to enhance showQueryErrorMessage() function to receive/print error message or at least an error code . It will allow us tracing issues and finding a root cause of the failure quickly.

igkislev
igkislev previously approved these changes Nov 6, 2025
Copy link
Contributor

@jonasg-gc jonasg-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix spelling in comments: "Comma" not "coma"

@GormFrank
Copy link
Contributor Author

Please fix spelling in comments: "Comma" not "coma"

Done!

@jonasg-gc jonasg-gc merged commit 3982124 into ServiceCanada:main Nov 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants