Skip to content

WET-616: New CR on Nov.17#27

Merged
Garneauma merged 1 commit intoServiceCanada:mainfrom
polmih:wet-616
Nov 21, 2025
Merged

WET-616: New CR on Nov.17#27
Garneauma merged 1 commit intoServiceCanada:mainfrom
polmih:wet-616

Conversation

@polmih
Copy link
Collaborator

@polmih polmih commented Nov 18, 2025

No description provided.

Copy link
Collaborator

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the change request and please update the content page with the latest styles for labels.

@Garneauma
Copy link
Collaborator

API changes:

  • Patch - Buttons: scoped .btn-link styles to .oag-card context
  • Patch - Labels: updated labels colors
  • Patch - Tabs: vertical tabs fix after WET-BOEW release which impacted this variant
  • Patch - Audit report details: adding spacing in edge case implementation

Copy link

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that 2 of the colors used for labels do not meet the WCAG minimum contrast ratio of 4.5:1.

The two colors are:

  • --oag-golden-sand: #89AF7C
  • --oag-light-green: #E9C267

Here's the demo link (thank you @polmih): https://polmih.github.io/oag-template/

@duclosph
Copy link

I just noticed that 2 of the colors used for labels do not meet the WCAG minimum contrast ratio of 4.5:1.

The two colors are:

  • --oag-golden-sand: #89AF7C
  • --oag-light-green: #E9C267

Here's the demo link (thank you @polmih): https://polmih.github.io/oag-template/

Let's go for this:

Commissioner of the environment and sustainable development reports label
text #fff
bg #3f5530

Special examinations of crown corporations label
text #333
bg #E9C267

@duboisp
Copy link

duboisp commented Nov 21, 2025

Note: I reviewed the color contrast proposed by @duclosph , and it does pass the contrast ratio needed by WCAG 2

@polmih can you apply that change? Thanks

@polmih
Copy link
Collaborator Author

polmih commented Nov 21, 2025

Note: I reviewed the color contrast proposed by @duclosph , and it does pass the contrast ratio needed by WCAG 2

@polmih can you apply that change? Thanks

The suggested changes are now applied

@duboisp
Copy link

duboisp commented Nov 21, 2025

@duclosph can you quickly review this working example and let us know if it is all good to move ahead.

Thanks

@duclosph
Copy link

@duclosph can you quickly review this working example and let us know if it is all good to move ahead.

Thanks

Looks good! :)

@duboisp
Copy link

duboisp commented Nov 21, 2025

@BeraJosh for your review

Copy link

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Garneauma Garneauma merged commit f7e6d0d into ServiceCanada:main Nov 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants