Open
Conversation
|
Hello, any chances this bug gets fixed/merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request (PR) do? / Que fait cette demande « pull » (PR)?
This PR fixes a bug where, when a user's system language was set to french, the
lastDateIMShowncookie would contain non-ascii characters (ex.lastDateIMShown=Tue Nov 05 2024 11:09:11 GMT-0500 (heure normale de l’Est)) which breaks the RFC6265 standard, and causes any requests to any server under the *.cyber.gc.ca (all of our apps) to be refused because of invalid headers.Additional information (optional) / Information additionnelle (optionel)
This PR contains a simple fix where the date stored is converted to a timestamp int which avoids special characters altogether, and also adds "www." in front of the cookie domain, making it only match the exact domain and not the subdomains. For example, in the case of cyber.gc.ca, the cookie will only exist for www.cyber.gc.ca, but not for www.other.apps.cyber.gc.ca
General checklist / Liste de contrôle générale
Make your own list for the purpose of your Pull request. /// Faites votre propre liste en fonction des besoins de votre demande « pull ».
Related issues / Requêtes associées
List issues that are being closed or worked on with this pull request i.e. Closes #8 /// Listez les autres requêtes (« issues » ou PR) qui sont fermées ou traitées avec cette demande de retrait ex. : Closes #8
Screenshots / Captures d'écrans
If applicable, add screenshots to help demonstrate what this PR does. /// Si applicable, ajoutez des captures d'écran pour aider à démontrer ce que cette PR fait.