Automatically pickup items when cutting down trees (1.21.0)#2
Open
IxPrumxI wants to merge 2 commits intoSerilum:1.21.0from
Open
Automatically pickup items when cutting down trees (1.21.0)#2IxPrumxI wants to merge 2 commits intoSerilum:1.21.0from
IxPrumxI wants to merge 2 commits intoSerilum:1.21.0from
Conversation
IxPrumxI
commented
Aug 11, 2024
|
|
||
| Block block = Block.byItem(itemStack.getItem()); | ||
| BlockPos yZeroPlayerPos = player.getOnPos().atY(0); | ||
| // BlockPos yZeroItemPos = leafPos.atY(0); |
Author
There was a problem hiding this comment.
@ricksouth I wish to hear your input on this. Should it search based on the player position or the leaf position?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I only tested on Fabric 1.21.0
When cutting down a tree this will pick up all items, If there's no place for the items it will mimck vanilla behaviour of dropping the items where the block was destoryed.
Closes Serilum/.issue-tracker#1998