Implement stricter authentication. #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow unauthenticated or guest/split-screen connections by default. This can be bypassed with a new server property.
AnyBananaGAME
suggested changes
Sep 18, 2025
Contributor
AnyBananaGAME
left a comment
AnyBananaGAME
left a comment
There was a problem hiding this comment.
mIght want to change this
import { AuthenticationType } from "@serenityjs/protocol/src/types/authentication-type";in login.ts
Contributor
|
Looks good, but authentication-type could be spoofed without any problems, so it doesn't add much security/protection. We have implemented full authentication in latest versions, so this PR have to be changed a bit. Do you think you could add your config properties to the latest versions? At the moment we don't have options to disable authentication? But it might be easier to create new PR. I am not closing this PR yet, so let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow unauthenticated or guest/split-screen connections by default. This can be bypassed with a new server property.