Fix soft enum validation. #186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Added bad alias support to this PR because it's better than no alias support, and this is a missing feature currently as well. All I've done is register the command under each alias, if there is a better way to do this we can improve this for this pr or in the future. |
In my changes I stopped returning error messages for the player, but that's fixed now. my bad
Contributor
Author
|
I'm done making changes now (unless changes are requested to merge the pr). EDIT: nevermind, guess I'm not, lol |
Enums now have to validate to run an overload. This makes overloads a little more strict, but several times less prone to error. Also, better logging. :)
Contributor
|
@PMK744 I think this should get merged since no more edits are being pushed? |
Contributor
|
Is it up to date? Is it working properly? We want to make sure it doesn't break other stuff if possible. Also please run linter before commits but looks good i guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, soft enum validation was entirely broken. In some cases, you could enter any string value and it would validate it. In others, it would match a completely incorrect overload.
This fix will correctly validate overloads server-side, since we currently can't rely on client-side validation.
This is not an alternative to real enum support. Client will still not be able to differentiate between two enum overloads due to both using the string symbol, which renders overload feedback incorrect when typing a command using multiple enums. See my issue for more information.