Enforce defining impacts #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypcs
force-pushed
the
feature/impact
branch
4 times, most recently
from
2c8d369 to
5cae8fb
Compare
ypcs
force-pushed
the
feature/impact
branch
7 times, most recently
from
6f4a928 to
18fc242
Compare
This sets `Impact:` as required line in git commit messages. Goal is to make versioning easier, as each separate commit always defines it's impact on the overall stack. With this change, it should be easy to just read this line from all commits since previous version tag to see what would be the proper new version tag. Note: As pytest does not support executing parametrized tests when classes are based on top of unittest base classes, test cases have been duplicated manually. Gitlint base test suite (base.py) is imported from external repository, and Ruff is configured to ignore most of the issues with that file. Source: https://github.com/jorisroovers/gitlint/blob/4d9119760056492eabc201bfad5de2f9e660b85f/gitlint-core/gitlint/tests/base.py Commit: 4d9119760056492eabc201bfad5de2f9e660b85f License: MIT For more details about specs and features look for external documentation. See: https://docs.pytest.org/en/7.1.x/how-to/unittest.html#pytest-features-in-unittest-testcase-subclasses See: https://semver.org/ See: https://jorisroovers.com/gitlint/latest/rules/user_defined_rules/ Impact: minor Related: ICA-38 Closes: SGE-2228
ypcs
force-pushed
the
feature/impact
branch
2 times, most recently
from
ff1e376 to
5185afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets
Impact:as required line in git commit messages. Goal is to make versioning easier, as each separate commit always defines it's impact on the overall stack.With this change, it should be easy to just read this line from all commits since previous version tag to see what would be the proper new version tag.
Impact: major
Related: ICA-38
Closes: SGE-2228