Open
Conversation
In _getAllTemplates change try catch with .catch on first call to template.getTemplate, because template.getTemplate is a promise, with externally try catch the error is not catched. If you use this node in node-red (for example using node-red-contrib-cip-st-ethernet-ip), node-red crash with Uncaught Exception
Small change to commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Motivation, and Context
In _getAllTemplates changed try catch with .catch on first call to template.getTemplate, because template.getTemplate is a promise, with externally try catch the error is not catched.
If you use this node in node-red (for example using node-red-contrib-cip-st-ethernet-ip), node-red crash with Uncaught Exception
How Has This Been Tested?
I try this commit with my test environment (I have some rockwell plc that I read from like 1756-L82ES and 1756-L81ES)
This commit works in case of #21 : I think that try catch is inserted to resolve this issue.
Screenshots (if appropriate):
Types of changes
Checklist:
[WIP] Some awesome PR title)Related Issue
Major issue is Uncaught Exception on node-red