p006-Softmax-Activation in Javascript#171
Open
fisher2470 wants to merge 4 commits intoSentdex:masterfrom
Open
Conversation
- Layer_Dense function set to (2,5), resolved shape issue - Still working on a solution for max along axis with keepdims
|
The "p006-Softmax-Activation in Javascript.js" implementation has a major problem in the Softmax class implementation. Instead of calculation "batch-by-batch", it just combines all values in a single array and calculates the percentage in this single array. This is not the intended purpose of this class, and I suggest changing it to my implementation: class Activation_Softmax {
constructor () {}
forward (inputs) {
var exp_values = math.matrix(inputs._data.map(batch => batch.map(i => math.exp(i - math.max(batch)))));
var probabilities = math.matrix(exp_values._data.map(batch => batch.map(i => i / math.sum(batch))));
this.output = probabilities;
}
}Furthermore, it is advisable to only display the first 5 batches, as this is what the YouTube series does too. console.log(activation2.output._data.slice(0,5));The only issue I have is that all calculations assume a predefined matrix shape, which is 3 by whatever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves an error on p005 and includes the JavaScript solution for p006