Skip to content

Fix VectorStore lifecycle management and remove premature disposal #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeffreySu merged 2 commits into from
Nov 1, 2025
Merged

Fix VectorStore lifecycle management and remove premature disposal #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b5277c
Initial plan
Copilot Nov 1, 2025
71f9006
Fix VectorStore lifecycle management and remove incorrect using state…
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,12 @@ public static IWantToConfig ConfigVectorStore(this IWantToConfig iWantToConfig,
/// <param name="name"></param>
/// <param name="vectorStoreRecordDefinition"></param>
/// <returns></returns>
/// <remarks>
/// Note: VectorStore instances created in this method are not explicitly disposed.
/// The VectorStoreCollection returned may maintain a reference to the VectorStore and require it to remain alive.
/// For proper resource management, consider using dependency injection to manage VectorStore lifecycle
/// or ensure the collection is disposed when no longer needed.
/// </remarks>
public static VectorStoreCollection<TKey, TRecord> GetVectorCollection<TKey, TRecord>(this IWantToRun iWwantToRun, VectorDB vectorDb, string name, VectorStoreCollectionDefinition? vectorStoreRecordDefinition = null)
where TKey : notnull
where TRecord : class
Expand All @@ -264,11 +270,9 @@ public static VectorStoreCollection<TKey, TRecord> GetVectorCollection<TKey, TRe
case VectorDBType.Redis:
{
database = ConnectionMultiplexer.Connect(vectorDb.ConnectionString).GetDatabase();
using (var redisVectorStore = new RedisVectorStore(database,
new() { StorageType = RedisStorageType.Json }))
{
collection = redisVectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
}
vectorStore = new RedisVectorStore(database,
new() { StorageType = RedisStorageType.Json });
collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
break;
}
case VectorDBType.Milvus:
Expand Down
Loading