Wrap disposable vector stores in using statements to prevent resource leaks#161
Merged
JeffreySu merged 2 commits intoDeveloper-MicrosoftMemoryKernelfrom Nov 1, 2025
Merged
Conversation
…sposal Co-authored-by: JeffreySu <2281927+JeffreySu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP to address feedback on memory kernel changes
Wrap disposable vector stores in using statements to prevent resource leaks
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code analysis flagged that
InMemoryVectorStoreandQdrantVectorStoreinstances were created but never disposed, causing resource leaks.Changes
InMemoryVectorStorecreation in Memory and default cases withusingstatementsQdrantVectorStorecreation withusingstatementvectorStorevariable declarationThis follows the pattern already established for
RedisVectorStorein commit bb6eda4, ensuring consistent resource management across all vector store types.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.