feat(src20): emit Approval event to both owner and spender#131
Merged
ameya-deshmukh merged 2 commits intomainfrom Mar 25, 2026
Merged
feat(src20): emit Approval event to both owner and spender#131ameya-deshmukh merged 2 commits intomainfrom
ameya-deshmukh merged 2 commits intomainfrom
Conversation
Symmetric with Transfer events — emitApprovalEncrypted now emits the Approval event to both the owner and spender independently, each encrypted with their own AES key if registered.
Add 4 permit tests covering all key-registration combinations (both have keys, only owner, only spender, neither) to match the transferFrom coverage pattern for Transfer events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emitApprovalEncryptednow emits theApprovalevent to both the owner and spender, matching the existingemitTransferEncryptedpattern.Test plan
sforge test --match-contract SRC20EventsTest --match-test test_Approve🤖 Generated with Claude Code