test(viem): fix sreth trace integration tests#129
Merged
Conversation
Txs were being sent with 30M gas limit, which after https://eips.ethereum.org/EIPS/eip-7825 wasnt allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Txs were being sent with 30M gas limit, which after https://eips.ethereum.org/EIPS/eip-7825 wasnt allowed (max gas per tx is now ~16M).
Note
The above EIP is enabled in Osaka.
We enable osaka in our dev.json genesis file.
However our official SpecId enum sets our MERCURY specid before Osaka.
This choice is safe since we've built our code on an upstream commit that was pre official osaka release (1.9.3).
So I think we should probably either: