fix(seismic-viem): fetch latest block hash after other RPC calls#123
Open
fix(seismic-viem): fetch latest block hash after other RPC calls#123
Conversation
3 tasks
drappi-ai
force-pushed
the
cdai__fix-stale-latest-block-hash
branch
from
cdd68d4 to
3a32573
Compare
Move resolveBlockParams() out of Promise.all so it runs after nonce and chainId resolution. This minimizes the window between fetching the latest block hash and using it in the transaction, reducing the chance of submitting a stale recentBlockHash.
drappi-ai
force-pushed
the
cdai__fix-stale-latest-block-hash
branch
from
3a32573 to
6cbbb97
Compare
drappi-ai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
resolveBlockParams()out ofPromise.allso it runs after nonce and chainId resolution. This minimizes the window between fetching the latest block hash and using it in the transaction, reducing the chance of submitting a stalerecentBlockHash.Users reported
recentBlockHashvalues that were minutes to hours stale. We traced the full stack (viem transport, nginx, reth node) and confirmed the node returns fresh blocks — the staleness originates from some intermediate layer in the browser/dapp environment. By deferring the block fetch to the last possible moment, we shrink the staleness window regardless of the root cause.Test plan
bun run typecheckpassesbun run viem:test)