feat!(seismic-tx): extend tx with 7702 auth_list#332
Conversation
PR Review SummaryReviewed commit: ChangesAdds an Blocking Issues1. When building a authorization_list: vec![],If the Seismic node serializes a non-empty auth list in its RPC response (which the upstream seismic-alloy PR #82 presumably adds), this conversion will silently drop it. The downstream effect is a different sighash, causing incorrect sender recovery and breaking any code path that re-signs or re-verifies the deserialized transaction. The 2. Missing compact codec test for non-empty The only compact roundtrip test constructs a
Suggestions1. TODO comments in
2. Positive Notes
|
7c4163f to
7409c7d
Compare
|
@claude fixed your 2 blocking issues:
|
Re-Review SummaryReviewed commit: Previously Flagged — Now Resolved
Previously Flagged — Still Unresolved
New Issues in Fix CommitsNone found. New Suggestions
|
61a0176 to
7c27124
Compare
|
rebased on top of #336 |
We just bump the dependencies of other repos to get the new tx type, and then chain it everywhere needed.
7c27124 to
50e7b6e
Compare
|
rebased on top of #340 |
Group of related PRs:
We just bump the dependencies of other repos to get the new tx type, and then chain it everywhere needed.
Note that this is a breaking change, since the tx's rlp encoding is changed, which breaks all of: wire format, db format (whats stored in tx trie), and signatures (signing over different rlp encoding).