Add some motion IDs and fields, also add MarioJumpFallPara fields#2
Open
JohnP55 wants to merge 1 commit intoSeekyCt:masterfrom
Open
Add some motion IDs and fields, also add MarioJumpFallPara fields#2JohnP55 wants to merge 1 commit intoSeekyCt:masterfrom
JohnP55 wants to merge 1 commit intoSeekyCt:masterfrom
Conversation
Owner
|
Huh, apparently this never got merged? I thought I'd left a review forever ago but it doesn't seem to be here. I can add the information to spm-headers if it's still considered up to date, though your ghidra seems to disagree with some of the field names |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.