Skip to content

Os dependent checksum #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SeanTCoder wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Os dependent checksum #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eaf4f2
make the check sum generation of sql and sqlFile changes independent …
Vampire Feb 7, 2014
4c1a5cb
make the check sum generation of the createProcedure change independe…
Vampire Feb 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion liquibase-core/src/main/java/liquibase/change/AbstractSQLChange.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public CheckSum generateCheckSum() {
}

if (sql != null) {
stream = new ByteArrayInputStream(sql.getBytes());
stream = new ByteArrayInputStream(sql.getBytes("UTF-8"));
}

return CheckSum.compute(new NormalizingStream(this.getEndDelimiter(), this.isSplitStatements(), this.isStripComments(), stream), false);
Expand Down
7 changes: 6 additions & 1 deletion liquibase-core/src/main/java/liquibase/change/core/CreateProcedureChange.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.UnsupportedEncodingException;

@DatabaseChange(name = "createProcedure",
description = "Defines the definition for a stored procedure. This command is better to use for creating procedures than the raw sql command because it will not attempt to strip comments or break up lines.\n\nOften times it is best to use the CREATE OR REPLACE syntax along with setting runOnChange='true' on the enclosing changeSet tag. That way if you need to make a change to your procedure you can simply change your existing code rather than creating a new REPLACE PROCEDURE call. The advantage to this approach is that it keeps your change log smaller and allows you to more easily see what has changed in your procedure code through your source control system's diff command.",
Expand Down Expand Up @@ -178,7 +179,11 @@ public CheckSum generateCheckSum() {
}

if (procedureText != null) {
stream = new ByteArrayInputStream(procedureText.getBytes());
try {
stream = new ByteArrayInputStream(procedureText.getBytes("UTF-8"));
} catch (UnsupportedEncodingException e) {
throw new AssertionError("UTF-8 is not supported by the JVM, this should not happen according to the JavaDoc of the Charset class");
}
}

CheckSum checkSum = CheckSum.compute(new AbstractSQLChange.NormalizingStream(";", false, false, stream), false);
Expand Down