Skip to content

Conversation

@brennoo
Copy link
Contributor

@brennoo brennoo commented Oct 14, 2025

so users with tls-enabled redis can connect viarediss:// - also added support for specifying the database

Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
@brennoo brennoo force-pushed the add_redis_protocol branch from 6414275 to b0b96db Compare October 14, 2025 18:43
Copy link
Owner

@ScribblerCoder ScribblerCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. If you can please add

  • .Values.redis.external.protocol
  • .Values.redis.external.database
    in values.yaml and leave them to default values. To guide users who want to enable TLS, and also for helm-docs

Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
@brennoo
Copy link
Contributor Author

brennoo commented Oct 15, 2025

Thanks for the PR. If you can please add

* `.Values.redis.external.protocol`

* `.Values.redis.external.database`
  in values.yaml and leave them to default values. To guide users who want to enable TLS, and also for helm-docs

thanks for the quick review, done

@ScribblerCoder
Copy link
Owner

LGTM

@ScribblerCoder ScribblerCoder merged commit eb1adb5 into ScribblerCoder:main Oct 15, 2025
1 check passed
@brennoo brennoo deleted the add_redis_protocol branch October 15, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants