support 'target IDs' to enable traceability of which target ID powers temperature scores

[aleks-sch]

cc @remi-schroders @grace-schroders

requirement to support 'target IDs' to enable traceability of which target ID powers temperature scores. is related to email trail screenshotted at end of this comment

• new IDataProviderTarget optional field target_ids
• logic to preserve target_ids as part of target_validation and temperature_score
• test case EndToEndTest::test_target_ids to demonstrate target_ids being persisted through model for each case
• merge add try/except to CTA-file request.get request for company firewall #308 before this PR (could not develop locally without that change)

still TODO

• bump version number in setup.py

---

[aleks-sch]

hi @mountainrambler can you plz take a look at this PR? Do you see any major issues? the new field is optional and should not degrade existing temperature score methodology

[mountainrambler]

already squashed and merged

[mountainrambler]

Please do note reference a specific data provider. Make it generic. There are other data providers that also wish to see a target id.

[mountainrambler]

Looks good, and thanks for the PEP8 updates and spelling corrections

[mountainrambler]

I've tested this PR and it works well. Special thanks for the cleaning up of comments and PEP8 related fixes. I did comment on the reference to a specific data provider in interfaces.py. Please update and make it generic, since there are other data providers that are interested in introduction a target ID.

Also, we need to update the docs in conjunction with this release. I propose adding a column at the end of the target_data tab in the data provider excel file and the corresponding info in the docs page on Data Legends. Are there any other things we need to fix in relation to target IDs?

[mountainrambler]

I suggest we bump this version to 1.1.0 since we are doing more than bug fixes. Then we can do the EOL on Python 3.7 afterwards and bump to 2.0.0. Thoughts?