Fix shared GeoAxes zoom not propagating to sibling subplots#2652
Open
guillermodotn wants to merge 1 commit intoSciTools:mainfrom
Open
Fix shared GeoAxes zoom not propagating to sibling subplots#2652guillermodotn wants to merge 1 commit intoSciTools:mainfrom
guillermodotn wants to merge 1 commit intoSciTools:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
When using
sharex/shareyon cartopy GeoAxes, interactive zoom does not propagate to sibling subplots after adding features._draw_preprocess()callsautoscale_view()on every draw, resetting all shared limits to full extent._get_extent_geom()compounds this by callingautoscale_view()insidehold_limits(), which propagates resets to siblings but only restores the current axes.Closes #2637
Implications
_draw_preprocess(): clearignore_existing_data_limitsafter the firstautoscale_view(), matching matplotlib's own pattern._get_extent_geom(): readviewLimdirectly instead of callingautoscale_view(). AdataLimfallback handles the pre-draw case.