Fix gridline labels ignoring side visibility on curved projections#2649
Open
guillermodotn wants to merge 1 commit intoSciTools:mainfrom
Open
Fix gridline labels ignoring side visibility on curved projections#2649guillermodotn wants to merge 1 commit intoSciTools:mainfrom
guillermodotn wants to merge 1 commit intoSciTools:mainfrom
Conversation
|
Is there a way to fix this without having to update the version once this comes in? I'm trying to plot something and I am having trouble getting the 60N and 60S to disappear: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
On non-rectangular projections (e.g. Robinson), gridline labels on the curved boundary get classified as
"geo"instead of a named side, bypassingright_labels=False(or equivalent).For example, 60°N and 60°S still appear on the right even when
gl.right_labels = False.Closes #2607
After fix sample:

Implications
_draw_gridliner: when a label'slocis"geo", also check the angle-derived side attribute. Usesis Falseto avoid changing default behavior for users who haven't explicitly disabled a side.