FIX: Handle empty points in geometry projection#2640
Merged
rcomer merged 1 commit intoSciTools:mainfrom Mar 15, 2026
Merged
Conversation
rcomer
approved these changes
Mar 15, 2026
Member
rcomer
left a comment
rcomer
left a comment
There was a problem hiding this comment.
Seems right. The doc build failure is troubling but also appearing in other PRs so nothing to do with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we didn't have a check for an empty
shapely.Point(), but did have an empty array check on thetransform_points()method. The error is in the attribute look-up, which we can avoid by just returning the empty point directly since it can't be transformed anyways.closes #2635