Improve explicit imports hygiene#86
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Jan 12, 2026
Merged
Conversation
This commit addresses all explicit imports issues identified by ExplicitImports.jl: ## Changes Made 1. **Fixed implicit imports in src/ODEInterfaceDiffEq.jl**: - Added explicit imports for `BinaryMaxHeap`, `BinaryMinHeap`, `counter` from DataStructures - Added explicit imports for `CallbackSet`, `ReturnCode`, `VectorContinuousCallback`, `check_keywords`, `warn_compat` from SciMLBase - Added explicit import for `I` from LinearAlgebra - Added explicit module imports for `Compat`, `FunctionWrappers`, `ODEInterface`, `SciMLBase` - Added explicit import for module name `DiffEqBase` to support qualified function extensions - Added `initialize!` and `savevalues!` to DiffEqBase imports for proper function extension 2. **Added ExplicitImports test suite**: - Created test/explicit_imports.jl to check for implicit and stale imports - Added ExplicitImports to [extras] section in Project.toml - Integrated test into runtests.jl 3. **All tests pass**: Full test suite runs successfully including the new ExplicitImports checks The package now follows best practices for explicit imports with no implicit or stale imports. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses all explicit imports issues identified by ExplicitImports.jl and adds CI tests to prevent regressions.
Changes Made
Fixed implicit imports in src/ODEInterfaceDiffEq.jl:
BinaryMaxHeap,BinaryMinHeap,counterfrom DataStructuresCallbackSet,ReturnCode,VectorContinuousCallback,check_keywords,warn_compatfrom SciMLBaseIfrom LinearAlgebraCompat,FunctionWrappers,ODEInterface,SciMLBaseDiffEqBaseto support qualified function extensionsinitialize!andsavevalues!to DiffEqBase imports for proper function extensionAdded ExplicitImports test suite:
All tests pass: Full test suite runs successfully including the new ExplicitImports checks
Benefits
Test Results
All existing tests continue to pass.
cc @ChrisRackauckas
🤖 Generated with Claude Code