Fix overdetermined initialization in Element1D and ConvectiveElement1D #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MTK v11, the syntax
dT(t) = dTwith a constant value creates aninitial_condition, which adds an initialization equation. For algebraic
variables like
dTandQ_flowthat are constrained by equations(e.g.,
dT ~ port_a.T - port_b.T), this creates an overdeterminedinitialization system.
The fix changes from initial conditions to guesses:
dT(t) = dT, [guess = 0.0](dT arg as initial condition)dT(t), [guess = dT_guess](dT_guess arg as guess only)This follows the MTK v11 semantics where algebraic/observed variables
should only have guesses, not initial conditions.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.