WIP: makes needleslot left-aligned in needleunit #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, needleunits have centred needleslots. This leads to thin walls on each side of the needlebed, which are prone to breaking off. This is at its worst on 4.5mm gauge. This commit adjusts the needleslot to be left-aligned. This changes the overall geometry of the needlebed and required additional adjustments to the spongebar and backcover parts. A small change may still be needed on the left mounting bracket. As this part is currently undergoing refactoring, this was deferred. For this reason, the new parts have not yet been test-printed! The needleslot not being left-aligned has one major downside: The left-most needle on each needlebed has no support when the knitting machine is disassembled. It will fall out, unless secured by tape or other means.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, needleunits have centred needleslots. This leads to thin walls on each side of the needlebed, which are prone to breaking off. This is at its worst on 4.5mm gauge.
This commit adjusts the needleslot to be left-aligned. This changes the overall geometry of the needlebed and required additional adjustments to the spongebar and backcover parts. A small change may still be needed on the left mounting bracket. As this part is currently undergoing refactoring, this was deferred. For this reason, the new parts have not yet been test-printed!
The needleslot not being left-aligned has one major downside: The left-most needle on each needlebed has no support when the knitting machine is disassembled. It will fall out, unless secured by tape or other means.