Conversation
|
@ScalarVector1 Is this PR ok to merge? |
|
|
||
| public override string Name => mod.DisplayName; | ||
|
|
||
| public override string Description => mod.DisplayName; |
There was a problem hiding this comment.
Should have a real description here or a localization key get, dont just repeat the name
There was a problem hiding this comment.
Should have a real description here or a localization key get, dont just repeat the name
Added localization entry for Description
| Texture2D tex = null; | ||
|
|
||
| string path = $"{mod.Name}/icon_small"; | ||
| string dlPath = $"{mod.Name}/icon"; |
There was a problem hiding this comment.
Would prefer a default asset with a more fitting size, Assets.Filters.Vanilla may work well?
| if (mod.Name == "DragonLens") | ||
| tex = ModContent.Request<Texture2D>(dlPath).Value; | ||
| if (ModContent.HasAsset(path)) | ||
| tex = ModContent.Request<Texture2D>(path).Value; |
There was a problem hiding this comment.
this would override if DL ever adds an icon_small, is this the intended behavior?
There was a problem hiding this comment.
Ideally if this does happen the external logic checkifn tfor the mod is removed
There was a problem hiding this comment.
Done, used vanilla asset for DragonLens tools
|
@ScalarVector1 Updated with your comments Demo: |
|
@ScalarVector1 Hi, is the latest updates ok? |
2 participants
Description:
See issue #141
Testing:
Testing was done with multiple mod scenarios:
ToolsTool'sAll scenarios act as expected, showing only mods which add tools.
Changes:
Added the new
ToolModFilterclass and use it inBrowserToolclass inSetupFiltersmethod.Demo:
dotnet_eNI5LD8whp.mp4