Open
Conversation
Collaborator
StillFantastic
left a comment
StillFantastic
left a comment
There was a problem hiding this comment.
The Supra integration part looks good to me.
Only a small suggestion.
Comment on lines
+300
to
+302
| _beforeRepayDebt(_debtAmount); | ||
|
|
||
| IBorrowerOperationsFacet(xApp).repayDebt(troveManager, msg.sender, _debtAmount, _upperHint, _lowerHint); |
Collaborator
There was a problem hiding this comment.
Consider refactoring a bit to reuse existing code by callingrepayDebt here for example?
Collaborator
StillFantastic
left a comment
StillFantastic
left a comment
There was a problem hiding this comment.
Sorry I didn't make that very clear, the refactor can be applied to all the new functions, I think. But functionality-wise it should be the same so you can decide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.